Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding prerequisites to roman numerals, binary, hexadecimal, octal, s… #1919

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

meganriley
Copy link

…quare-root, trinary, all-your-base, minesweeper, queen-attach, react, and zipper (not darts)

…quare-root, trinary, all-your-base, minesweeper, queen-attach, react, and zipper (not darts)
@github-actions
Copy link
Contributor

Dear meganriley

Thank you for contributing to the JavaScript track on Exercism! 💙
You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

  • ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.

  • 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

  • 📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)

  • 🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.

  • 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

Automated comment created by PR Commenter 🤖.

Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This seems very reasonable.

@SleeplessByte
Copy link
Member

/format

@SleeplessByte
Copy link
Member

Closing and re-opening to trigger CI

@SleeplessByte
Copy link
Member

The failing CI is not your doing. It's because that tool has updated and now is complaining about a new (previously non-existent) rule.

@tejasbubane
Copy link
Member

@SleeplessByte Is it safe to rename those topic names? Will it break anything for in-progress or completed exercises on the live site?

@SleeplessByte
Copy link
Member

Safe to rename. Only occurrences should be in the repo itself. If we have a same named folder in concepts (not excercises, just the concepts folder) those should be renamed too but that's it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants