Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Basics] new concept #779

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[Basics] new concept #779

wants to merge 7 commits into from

Conversation

colinleach
Copy link
Contributor

For discussion on the forum.

This concept draft combines and rewrites 3 older concepts. It is paired with the Lasagna concept exercise.

concepts/basics/about.md Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One line per sentence per Exercism style guide

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also my general comments from the lasagna PR also apply to this text where applicable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The introduction.md is common to this and lasagna (apart from a couple of lines at the top), so I'll sync changes.

concepts/basics/about.md Outdated Show resolved Hide resolved
concepts/basics/links.json Outdated Show resolved Hide resolved
@colinleach colinleach changed the title [Basics] new concept exercise [Basics] new concept Sep 9, 2024
colinleach and others added 4 commits September 9, 2024 13:20
Co-authored-by: András B Nagy <20251272+BNAndras@users.noreply.github.com>
Co-authored-by: András B Nagy <20251272+BNAndras@users.noreply.github.com>
Co-authored-by: András B Nagy <20251272+BNAndras@users.noreply.github.com>
@depial
Copy link
Contributor

depial commented Sep 10, 2024

I hope you don't mind I've fixed a small typo, since I figured that was easier than pointing it out. Everything else looks good to me, though.

@colinleach
Copy link
Contributor Author

Thanks, I saw that earlier and thought I'd fixed it. These things breed and multiply when you're not looking...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants