generator: remove custom context #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic to extract the function names from the lib.rs stub to use it
for exercise generation doesn't really add any value, it just makes
things more complicated. First of all, the Rust code itself.
But also the tera templates, which contain a {{ fn_names[0] }}.
All for saving a few characters of typing when creating a new template.
That's not worth it in my opinion. The templating context should only
contain things that actually change dynamically, namely the test data.
senekor
commented
Mar 31, 2024
Comment on lines
-137
to
-139
| If every test case needs to do some crunching of the inputs, | ||
| you can add utils functions at the top of the tera template. | ||
| See [`word-count`'s template][word-count-tmpl] for an example. |
There was a problem hiding this comment.
This is a piggy-back, I removed this recommendation because of reasons explained in #1824
ErikSchierboom
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crate_nameandfn_nameswere previously injected into the context for rendering a test template to allow something like the following in a template:This made both the templates and Rust code for the generator more complicated. The benefit is only a few characters less typing when creating the template once. In hindsight, this is not worth it in my opinion.
[no important files changed]