travis: reject invalid UUIDs #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coriolinus
approved these changes
Aug 30, 2019
There was a problem hiding this comment.
Changes look good, and I see from the commit history that this does what it's meant to.
I have a low-strength preference that this feature be moved from .travis.yml into a new script file in _test, for consistency with the other tests, and so that it can be run independently. This preference is not strong enough to block merging as-is.
|
It shall be done (moved into a script) |
Want to prevent any invalid UUIDs from being entered. Want to put this in configlet lint, but can't: exercism/configlet#99 exercism/configlet#168 So it will go in individual tracks' .travis.yml for now. It appears that the site will accept pretty much arbitrary strings as UUIDs for now, but we want to make less work for ourselves when valid UUIDs are required.
too short, too long, non-hex char
This reverts commit 637db2b.
|
I have pretty high confidence in the tests, enough that I would consider just merging it now, but I'll leave it open for about 16 hours in case additional comments pop up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Want to prevent any invalid UUIDs from being entered.
Want to put this in configlet lint, but can't:
exercism/configlet#99
exercism/configlet#168
So it will go in individual tracks' .travis.yml for now.
It appears that the site will accept pretty much arbitrary strings as
UUIDs for now, but we want to make less work for ourselves when valid
UUIDs are required.