Fix Wordcount unit test for Xcode 6 beta 4 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for issue exercism#4
|
Let me know if that works for you, I noticed that the test suite for ETL suffers of the same issue. |
|
This is a very nice solution to the missing XTCAssertEqualObjects problem. Hopefully Apple will fix the issue in a future beta and we can switch back, but for now I think your bridging approach is the right way to go. |
|
Great, I'll create more pull requests as I work through the exercisms once you merge this. @hankturowski, don't hesitate to nitpick my swift submissions. My exercism team doesn't have Swift experience. |
kytrinyx
added a commit
that referenced
this pull request
Aug 8, 2014
Fix Wordcount unit test for Xcode 6 beta 4
|
Thank you! |
|
You're welcome. I'll fix the next one as well. See you at E4E, @kytrinyx, looking fwd to your presentation |
|
I'm very excited about E4E, see you there! |
kytrinyx
added a commit
that referenced
this pull request
Oct 9, 2014
Fix Wordcount unit test for Xcode 6 beta 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #4
I imagine that's a correct approach until Swift Dictionary become Equatable or XTCAssertEqualObjects makes a come back