This repository has been archived by the owner on Mar 22, 2022. It is now read-only.
config: Only marshal Slug, UUID, Deprecated of deprecated exercises #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petertseng
force-pushed
the
deprecated
branch
2 times, most recently
from
53d2d8a
to
51ce804
Compare
We don't need any of the other fields, and it's deceptive to keep them in the JSON file because a maintainer may mistakenly believe them to be significant, but in fact they are not; the website does not display any of the removed fields: https://github.com/exercism/website/blob/b3314e84c52b52cf5f253386c3f0bf4127ca09aa/app/views/my/tracks/_show_side_exercises.html.haml#L26-L34 Two new tests were added: TestMarshalActive and TestMarshalDeprecated. TestMarshalActive passes both before and after the associated code change. TestMarshalDeprecated fails before the associated code change, and passes after. Closes exercism/configlet#140
petertseng
force-pushed
the
deprecated
branch
from
51ce804
to
002fbe9
Compare
|
I'd also consider not marshaling |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need any of the other fields, and it's deceptive to keep them
in the JSON file because a maintainer may mistakenly believe them to
be significant, but in fact they are not; the website does not display
any of the removed fields:
https://github.com/exercism/website/blob/b3314e84c52b52cf5f253386c3f0bf4127ca09aa/app/views/my/tracks/_show_side_exercises.html.haml#L26-L34
Two new tests were added: TestMarshalActive and TestMarshalDeprecated.
TestMarshalActive passes both before and after the associated code
change.
TestMarshalDeprecated fails before the associated code change, and
passes after.
Closes exercism/configlet#140