(chore) catch invalid json #26
Conversation
| - name: Ensure valid JSON | ||
| run: jq '.' config.json |
There was a problem hiding this comment.
This is actually a very nice idea. @ee7 @SaschaMann do we want to add this to the central configlet workflow to catch exercism/configlet#312?
There was a problem hiding this comment.
Great idea. Why didn't we think of this before? It's a good stop-gap measure until we have stricter parsing in configlet lint.
Created a draft PR here: exercism/github-actions#21
Maybe we can make this look obvious in the workflow log, rather than needing to do a mass PR to each track's configlet.yml.
Edit: The main downside is that people will only see that their JSON is invalid in CI, and not when running configlet lint locally. But I've just realised that we can just make configlet lint run jq when it's detected on the system (and/or when we're running in CI). Let's do that instead.
There was a problem hiding this comment.
But I've just realised that we can just make configlet lint run jq when it's detected on the system (and/or when we're running in CI). Let's do that instead.
Now we're thinking! :-) It could even recommend you install it...
No description provided.