Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update success check #14

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

m-dango
Copy link
Member

@m-dango m-dango commented Sep 4, 2024

Online test runner is reporting an error because 'All tests successful.' is not the final line.

@m-dango m-dango requested a review from a team as a code owner September 4, 2024 15:45
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why this wasn't caught by the tests? Is there a new test that we need to add?

@m-dango
Copy link
Member Author

m-dango commented Sep 5, 2024

There is some additional output which times the tests, but of course having different times causes these tests to fail so its trimmed out of the results. I can't remember off the top of my head (or maybe its changed since my initial implementation) where this happens.

@ErikSchierboom ErikSchierboom merged commit 88fb315 into exercism:main Sep 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants