Cleanup and address obsidian releases feedback #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristenbrann
commented
Mar 15, 2023
| @@ -1,4 +1,4 @@ | |||
| import { App, PluginSettingTab, Setting, SliderComponent } from 'obsidian' | |||
kristenbrann
commented
Mar 15, 2023
| getByFilePath(filePath: string): Vector { | ||
| return this.filePathToVector.get(filePath) as Vector | ||
| getByFilePath(filePath: string): Vector | undefined { | ||
| return this.filePathToVector.get(filePath) |
There was a problem hiding this comment.
no need to cast here
kristenbrann
commented
Mar 15, 2023
There was a problem hiding this comment.
unused code from initially incorporating react
kristenbrann
commented
Mar 15, 2023
| @@ -143,8 +143,12 @@ export default class VaultChat extends Plugin { | |||
| const searchResults = Array.from(nearestVectors.keys()) | |||
| const hydratedResults = [] | |||
| for (const searchResult of searchResults) { | |||
| const abstractFile = app?.vault.getAbstractFileByPath(searchResult) as TFile | |||
| const fileContentsOrEmpty = await app?.vault.read(abstractFile) | |||
| const abstractFile = this.app.vault.getAbstractFileByPath(searchResult) | |||
There was a problem hiding this comment.
don't access global app, instead using this.app
kristenbrann
commented
Mar 15, 2023
| const abstractFile = app?.vault.getAbstractFileByPath(searchResult) as TFile | ||
| const fileContentsOrEmpty = await app?.vault.read(abstractFile) | ||
| const abstractFile = this.app.vault.getAbstractFileByPath(searchResult) | ||
| if (!(abstractFile instanceof TFile)) { |
There was a problem hiding this comment.
check if result is actually a file and not a folder
kristenbrann
commented
Mar 15, 2023
There was a problem hiding this comment.
unused code from initially incorporating react
cpaika
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
obsidianmd/obsidian-releases#1752 (comment)