Adds hyde prompts for Ask ChatGPT command #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristenbrann
commented
Mar 19, 2023
cpaika
reviewed
Mar 19, 2023
cpaika
reviewed
Mar 19, 2023
cpaika
reviewed
Mar 19, 2023
cpaika
reviewed
Mar 19, 2023
| const nearestVectors = this.vectorStore.getNearestVectors(embeddingResponse, 8, this.settings.relevanceThreshold) | ||
| conversation.push(hydeMessage) | ||
| const hydeResponse = await this.openAIHandler.createChatCompletion(conversation) | ||
| if (!hydeResponse || hydeResponse.choices.length === 0 || !hydeResponse.choices[0].message) { |
There was a problem hiding this comment.
Improvement idea: instead of failing here, let's degrade and just search based on your search without the hyde. Does that make sense? Shouldn't be this PR.
I could imagine completions being unavailable but embeddings being fine, would be nice if we could recover and still serve limited functionality.
There was a problem hiding this comment.
Good idea! I agree. We should make this degrade to simple embeddings search. (Though in your example if completions was completely down the user wouldn't be successfully asking GPT any questions either.)
There was a problem hiding this comment.
true this would only apply to semantic search
cpaika
reviewed
Mar 19, 2023
cpaika
previously approved these changes
Mar 19, 2023
cpaika
approved these changes
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://arxiv.org/pdf/2212.10496.pdf
When you ask chatgpt a question, now we: