Adding path based file exclusions #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/VectorStore.ts
Outdated
| @@ -238,6 +255,10 @@ export class VectorStore { | |||
| } | |||
|
|
|||
| async addFile(file: TFile) { | |||
| if(this.isFileExcluded(file)) { | |||
| console.log("Skipping excluded file") | |||
There was a problem hiding this comment.
Make this a debug log or remove
src/VectorStore.ts
Outdated
| keysToBeDeleted.forEach(k => { | ||
| this.embeddings.delete(k) | ||
| }) | ||
| await this.saveEmbeddingsToDatabaseFile() // todo debounce |
There was a problem hiding this comment.
heh we need to consider this when merging #30 which does the debouncing 😈
src/main.ts
Outdated
| this.vectorStore.setExclusionPath(this.settings.exclusionPath) | ||
| this.vectorStore.deleteByPathPrefix() | ||
| const files = this.app.vault.getMarkdownFiles() | ||
| this.vectorStore.updateDatabase(files) // TODO trigger re-indexing |
src/UserSettings.ts
Outdated
| .onChange(async (value) => this.provisionalExclusionPath = value)) | ||
| .addButton(button => button. | ||
| setButtonText("Set Exclusion") | ||
| .onClick(async _ => { |
There was a problem hiding this comment.
what is the _ i haven't seen this syntax
There was a problem hiding this comment.
"Drop this variable, dont give it a name". NVM, what I wanted here was ()
src/VectorStore.ts
Outdated
| } | ||
|
|
||
| private isFilePathExcluded(file: string): boolean { | ||
| return (!!this.exclusionPath.trim() && file.startsWith(this.exclusionPath)) |
There was a problem hiding this comment.
do you know if its possible for this.exclusionPath to be null/undefined? to be safe, you may want to check that first
this.exclusionPath && !!this.exclusionPath.trim() && file.startsWith(this.exclusionPath)
src/VectorStore.ts
Outdated
| const keysToBeDeleted: string[] = [] | ||
| for (const key of this.embeddings.keys()) { | ||
| if(this.isFilePathExcluded(key)) { | ||
| console.log("Excluded Path:" + key) |
kristenbrann
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to exclude a path in your Vault with sensitive data from being sent to OpenAI for indexing. Intention is to support users who want this plugin's functionality, but want to keep some files private.
Fixes #20