Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPF record type #30

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Conversation

Th3Mouk
Copy link
Contributor

@Th3Mouk Th3Mouk commented Apr 30, 2020

Description

Add a missing const

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • I'm creating this PR to the develop branch.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

@styxit styxit self-assigned this Apr 30, 2020
Copy link
Member

@styxit styxit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Even though the SPF type should not be used anymore and it's advised to use TXT instead, PowerDNS still supports this type so it makes sense that this package also supports it.

If possible SPF rules should be defined in a TXT record: https://tools.ietf.org/html/rfc7208

@styxit styxit merged commit 08eb5e5 into exonet:master Apr 30, 2020
@styxit styxit mentioned this pull request Apr 30, 2020
3 tasks
@Th3Mouk Th3Mouk deleted the feature/add-spf-record branch April 30, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants