Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8 #54

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Add support for PHP 8 #54

merged 1 commit into from
Dec 14, 2020

Conversation

akondas
Copy link
Contributor

@akondas akondas commented Dec 14, 2020

Description

Adding support for PHP 8

Motivation and context

Installing the package on an environment with PHP 8

How has this been tested?

With run_tests.sh helper

Screenshots (if appropriate)

Screenshot from 2020-12-14 13-51-34

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

@trizz trizz self-assigned this Dec 14, 2020
@trizz
Copy link
Member

trizz commented Dec 14, 2020

Hi @akondas,

Thanks for your PR! I'll merge it to master, but I'm not tagging a release yet, as there are some more changes we like to add before releasing a new version. I'll expect a new release in the first or second week of january.

@trizz trizz merged commit e9abf3c into exonet:master Dec 14, 2020
@akondas akondas deleted the php8 branch December 14, 2020 14:10
@akondas
Copy link
Contributor Author

akondas commented Dec 14, 2020

Thanks for info 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants