Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for /servers/{server_id}/zones query parameter dnssec in PowerDns::listZones #61

Merged
merged 3 commits into from
Feb 1, 2021
Merged

Added support for /servers/{server_id}/zones query parameter dnssec in PowerDns::listZones #61

merged 3 commits into from
Feb 1, 2021

Conversation

frankvanhest
Copy link
Contributor

Performance improvement for PowerDns::listZones

Description

By adding support to include dnssec query parameter when calling /servers/{server_id}/zones you can set this to false to speed up the performance. With 12000 zones for example the time goes from ±8.8 seconds to ±0.9 seconds.

Motivation and context

See linked issue #60.

How has this been tested?

The unit test for listZones is changed to test the behaviour.
When comparing the results for dnssec query parameter set to true and false I couldn't see any difference with my local setup. My knowledge of PowerDNS is limited. So perhaps you can see a differents in the result from PowerDNS API.

Screenshots (if appropriate)

N/A

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • [N/A] If my change requires a change to the documentation, I have updated it accordingly.

@trizz
Copy link
Member

trizz commented Feb 1, 2021

Looking nice! Thanks!

@trizz trizz merged commit f82c712 into exonet:master Feb 1, 2021
@trizz trizz self-assigned this Feb 1, 2021
@styxit
Copy link
Member

styxit commented Feb 1, 2021

This has just been released in v3.1.0. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants