Added support for /servers/{server_id}/zones query parameter dnssec in PowerDns::listZones #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance improvement for PowerDns::listZones
Description
By adding support to include
dnssec
query parameter when calling/servers/{server_id}/zones
you can set this to false to speed up the performance. With 12000 zones for example the time goes from ±8.8 seconds to ±0.9 seconds.Motivation and context
See linked issue #60.
How has this been tested?
The unit test for listZones is changed to test the behaviour.
When comparing the results for dnssec query parameter set to
true
andfalse
I couldn't see any difference with my local setup. My knowledge of PowerDNS is limited. So perhaps you can see a differents in the result from PowerDNS API.Screenshots (if appropriate)
N/A
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist:
Go over all the following points, and put an
x
in all the boxes that apply.Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests pass.