Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docker service for PowerDNS 4.4 #73

Merged
merged 3 commits into from
Jun 7, 2021
Merged

Added docker service for PowerDNS 4.4 #73

merged 3 commits into from
Jun 7, 2021

Conversation

frankvanhest
Copy link
Contributor

@frankvanhest frankvanhest commented Jun 2, 2021

Extended the docker-compose.yml for PowerDNS 4.4

Description

The docker hub https://hub.docker.com/r/psitrax/powerdns does not have a tag for PowerDNS 4.4, but the tag latest has the correct version.
The pdns.conf is different in 4.4. The fields default-soa-name and default-soa-email are removed and replaced by default-soa-content.

It is best to use the tag 4.4 when it becomes available. For now this will at least prove that the code works for PowerDNS 4.4.

Motivation and context

I would love to have support for PowerDNS 4.4

fixes #66

How has this been tested?

By running run-tests.sh

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • [n/a] If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

@trizz trizz merged commit 5617512 into exonet:master Jun 7, 2021
@trizz
Copy link
Member

trizz commented Jun 7, 2021

@frankvanhest We've just tagged a release with your changes. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatible with PowerDNS 4.4?
2 participants