Allow onboarding at org level #2
Merged
+501
−200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpherndon
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
The changes generally LGTM, I would say though that the README bits could be improved if you make an editing pass and thoroughly disambiguate exactly which ID comes from where. There are places where you refer to "organization ID", and I don't know for certain if you are referring to the organization GUID as generated by workbench, or something from Google. I can assume you mean GCP, but, better to be explicit.
|
atlantis unlock |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
org_idvariable to allow for onboarding all clusters in a GCP organization to Expel Workbench. Instead of creating a log sink for a specific project, we create a log sink at the org level that includes logs from all child projects. The IAM custom role is also created at the org level, so Expel can discover clusters in the environment.