Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapping happens outside of runner #296

Merged
merged 12 commits into from
Oct 5, 2023
Merged

mapping happens outside of runner #296

merged 12 commits into from
Oct 5, 2023

Conversation

bertiqwerty
Copy link
Contributor

@bertiqwerty bertiqwerty commented Oct 2, 2023

Otherwise, strategies implemented outside of BoFire cannot use the runner to be evaluated and crappy strategies will become part of BoFire since they could not be evaluated beforehand 😉

@bertiqwerty bertiqwerty marked this pull request as ready for review October 2, 2023 15:39
@jduerholt
Copy link
Contributor

@bertiqwerty: I will have a look over the course of the week (hopefully tmr). Thanks for the PR.

Copy link
Contributor

@jduerholt jduerholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, I find it less elegant than the original version, as more code is needed for the user for standard tasks (before it was possible to just give the data model class as this was also a valid factory) but now it is more versatile. I think there is still a notebook in which it is not yet corrected.

@bertiqwerty
Copy link
Contributor Author

It looks good to me, I find it less elegant than the original version, as more code is needed for the user for standard tasks (before it was possible to just give the data model class as this was also a valid factory) but now it is more versatile. I think there is still a notebook in which it is not yet corrected.

Thanks @jduerholt. I think, I fixed them all and I got rid of some type-ignores 🥳. About the less-elegant-thing, I tend to disagree. I'd say it is less convenient. But it is more consistent with the way Bofire-users instantiate strategies. Further, you can now use it with strategies implemented outside of Bofire, e.g., during early experimentation or if you have a project-specific edge-case. These strategies could still inherit from Strategy. However, these outside-strategies are not registered in the mapper.

@bertiqwerty bertiqwerty merged commit 669fa44 into main Oct 5, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants