Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name construction in a method #395

Merged
merged 2 commits into from
May 17, 2024
Merged

name construction in a method #395

merged 2 commits into from
May 17, 2024

Conversation

bertiqwerty
Copy link
Contributor

@bertiqwerty bertiqwerty commented May 16, 2024

Make column names of categorical features and descriptors after encoding to, e.g., one-hot accessible from the outside and re-use the same code at all places inside BoFire.

@bertiqwerty bertiqwerty requested review from jduerholt and dlinzner-bcs and removed request for jduerholt May 16, 2024 12:09
@dlinzner
Copy link

I like it. approve.

Copy link
Contributor

@dlinzner-bcs dlinzner-bcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the wrong dominik linzner approved...

@bertiqwerty bertiqwerty merged commit d1207e4 into main May 17, 2024
10 checks passed
@jduerholt jduerholt deleted the expose-category-colnames branch May 17, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants