-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code example in README #410
Code example in README #410
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Toby!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just saw that one missing import makes the test fail. Further, you could put all imports to the top.
Co-authored-by: Behrang Shafei <50267830+bertiqwerty@users.noreply.github.com>
Test is failing due to a new scipy release from today. I try to figure it out this evening. Thanks @TobyBoyne! |
|
Thank you for investigating this @jduerholt! Will you be fixing this in the main branch? If so, please let me know once you have, and I will merge the changes. |
Hi Toby, the fix is now available in Main. Best, Johannes |
@bertiqwerty The fix has been merged, and this is now ready to close (if you're happy with my comment about moving all imports to the top, copied below)
|
Thanks Toby! |
Closes #409
Adds some examples of BoFire code (from the getting started notebook) to the README.