Cleanup. #4
Cleanup. #4
Conversation
| def self.start(config_path, hostapd_path) | ||
| networks = network_config config_path | ||
| # TODO: Is this rubyish? | ||
| if not networks.any? |
There was a problem hiding this comment.
Personally, I prefer the "full-method wrap" over guard clauses, i.e.
if networks.any?
all the code
end
This implies that you return nil instead of false, but since that's also falsy in a lot of situations it's better - but opinions on this differ, see this recent discussion I had with a bunch of my fellow contributors for simplecov
|
Very cool! Made a few stylistic remarks, but nothing really big. One thing that I'd personally prefer would be to now jump the extra hoop and make this all instance- instead of class-methods. This way you could do away with all the parametrization of the method calls since they'd just pull in from the config loaded in |
|
Thank you very much for the review and your suggestions! I've implemented most of them. |
|
👏 |
|
💃 |
Turns out that we actually need less than 25% of the legacy code.