Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require that all SpanGroup spans are from the current doc #12569

Merged
merged 2 commits into from
Jun 1, 2023

Commits on Apr 24, 2023

  1. Require that all SpanGroup spans are from the current doc

    The restriction on only adding spans from the current doc were already
    implemented for all operations except for `SpanGroup.__init__`.
    
    Initialize copied spans for `SpanGroup.copy` with `Doc.char_span` in
    order to validate the character offsets and to make it possible to copy
    spans between documents with differing tokenization. Currently there is
    no validation that the document texts are identical, but the span char
    offsets must be valid spans in the target doc, which prevents you from
    ending up with completely invalid spans.
    adrianeboyd committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    b9c3045 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. Configuration menu
    Copy the full SHA
    5dcad99 View commit details
    Browse the repository at this point in the history