Temporary Commit at 11/13/2024, 2:20:15 PM

expo · Nov 20, 2024 · 9eb89a7 · 9eb89a7
1 parent b0f20b0
commit 9eb89a7
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 21 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,8 @@ This is the log of notable changes to EAS CLI and related packages.
 
 ### 🎉 New features
 
+- Calculate fingerprint on each update. ([#2687](https://github.com/expo/eas-cli/pull/2687) by [@quinlanj](https://github.com/quinlanj))
+
 ### 🐛 Bug fixes
 
 ### 🧹 Chores

diff --git a/packages/eas-cli/src/project/publish.ts b/packages/eas-cli/src/project/publish.ts
@@ -50,7 +50,7 @@ import { truthy } from '../utils/expodash/filter';
 import groupBy from '../utils/expodash/groupBy';
 import mapMapAsync from '../utils/expodash/mapMapAsync';
 import uniqBy from '../utils/expodash/uniqBy';
-import { createFingerprintsByKeyAsync } from '../utils/fingerprintCli';
+import { FingerprintOptions, createFingerprintsByKeyAsync } from '../utils/fingerprintCli';
 import { Client } from '../vcs/vcs';
 
 // update publish does not currently support web
@@ -908,12 +908,12 @@ export async function maybeCalculateFingerprintForRuntimeVersionInfoObjectsWitho
     runtimeToPlatformsAndFingerprintInfoAndFingerprintSourceMapping.filter(
       infoGroup => !infoGroup.fingerprintHash
     );
-  const fingerprintOptionsByRuntimeAndPlatform = new Map();
+  const fingerprintOptionsByRuntimeAndPlatform = new Map<string, FingerprintOptions>();
   for (const infoGroup of runtimesToComputeFingerprintsFor) {
     for (const platform of infoGroup.platforms) {
       const runtimeAndPlatform = `${infoGroup.runtimeVersion}-${platform}`;
       const options = {
-        platform,
+        platforms: [platform],
         workflow: workflowsByPlatform[platform],
         projectDir,
         env,

diff --git a/packages/eas-cli/src/utils/fingerprintCli.ts b/packages/eas-cli/src/utils/fingerprintCli.ts
@@ -5,15 +5,17 @@ import mapMapAsync from './expodash/mapMapAsync';
 import Log from '../log';
 import { ora } from '../ora';
 
+export type FingerprintOptions = {
+  workflow: Workflow;
+  platforms: string[];
+  debug?: boolean;
+  env: Env | undefined;
+  cwd?: string;
+};
+
 export async function createFingerprintAsync(
   projectDir: string,
-  options: {
-    workflow: Workflow;
-    platforms: string[];
-    debug?: boolean;
-    env: Env | undefined;
-    cwd?: string;
-  }
+  options: FingerprintOptions
 ): Promise<{
   hash: string;
   sources: object[];
@@ -58,13 +60,7 @@ export async function createFingerprintAsync(
 async function createFingerprintWithoutLoggingAsync(
   projectDir: string,
   fingerprintPath: string,
-  options: {
-    workflow: Workflow;
-    platforms: string[];
-    debug?: boolean;
-    env: Env | undefined;
-    cwd?: string;
-  }
+  options: FingerprintOptions
 ): Promise<{
   hash: string;
   sources: object[];
@@ -99,10 +95,7 @@ async function createFingerprintWithoutLoggingAsync(
  */
 export async function createFingerprintsByKeyAsync(
   projectDir: string,
-  fingerprintOptionsByKey: Map<
-    string,
-    { workflow: Workflow; platforms: string[]; debug?: boolean; env: Env | undefined }
-  >
+  fingerprintOptionsByKey: Map<string, FingerprintOptions>
 ): Promise<
   Map<
     string,