Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] remove unnecessary static project config context definition from eas build command #2521

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Aug 27, 2024

Why

#2519

I was able to reproduce the issue and it is indeed true. It seems like we mistakenly added a static project config definition to the eas build command context in 56510f0#diff-cd2e00f4d286a4714f8736e14c635f4c3b98c402367cd71a83e4cd743034bd79. The output from it wasn't really used anywhere, but adding it caused the app configs to be evaluated without buildProfile.env in the first pass when trying the resolve project ID and slug at the begging of command execution and our slug/project ID assertions to fail. It only affected people with dynamic project IDs and slug fields.

How

Remove unnecessary static context from context definitions, therefore avoid resolving project ID and slug from app config without env vars as a first thing when the eas build command is executed.

Test Plan

Tested manually

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @szdziedzic and the rest of your teammates on Graphite Graphite

Copy link

github-actions bot commented Aug 27, 2024

Size Change: -89 B (0%)

Total Size: 51.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.4 MB -89 B (0%)

compressed-size-action

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.59%. Comparing base (6350258) to head (7541c5f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2521   +/-   ##
=======================================
  Coverage   52.59%   52.59%           
=======================================
  Files         548      548           
  Lines       20409    20409           
  Branches     4163     4163           
=======================================
  Hits        10732    10732           
  Misses       8837     8837           
  Partials      840      840           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic marked this pull request as ready for review August 27, 2024 13:14
Copy link

✅ Thank you for adding the changelog entry!

@szdziedzic szdziedzic merged commit 28592f2 into main Aug 27, 2024
10 checks passed
@szdziedzic szdziedzic deleted the 08-27-_eas-cli_remove_unnecessary_static_project_config_context_definition_from_eas_build_command branch August 27, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants