[eas-cli] add new entitlements added after Xcode 15.0+ #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @szdziedzic and the rest of your teammates on |
sjchmiela
approved these changes
Sep 2, 2024
szdziedzic
force-pushed
the
08-30-_eas-cli_add_new_entitlements_added_after_xcode_15.0_
branch
from
cbb3553
to
d0e3997
Compare
|
✅ Thank you for adding the changelog entry! |
|
Size Change: -958 B (0%) Total Size: 52.3 MB
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2525 +/- ##
=======================================
Coverage 52.59% 52.59%
=======================================
Files 548 548
Lines 20409 20409
Branches 4163 4163
=======================================
Hits 10732 10732
Misses 8837 8837
Partials 840 840 ☔ View full report in Codecov by Sentry. |
szdziedzic
deleted the
08-30-_eas-cli_add_new_entitlements_added_after_xcode_15.0_
branch
3 tasks
szdziedzic
added a commit
to expo/expo
that referenced
this pull request
Sep 9, 2024
# Why Companion to expo/eas-cli#2525 # How Add info about new capabilities we support # Test Plan Preview # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
companion to https://github.com/expo/third-party/pull/104
How
This is my first PR adding new capabilities so please double-check if I did everything correctly, I based it on 6389f52
I got new entitlements from https://developer.apple.com/documentation/bundleresources/entitlements?changes=latest_major and added all available capabilities corresponding to these.
Test Plan
Run prod build manually, add new entitlements for new capabilities to app config, and verify that they were enabled on the provisioning profile