Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] update expo packages #2530

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Sep 2, 2024

Why

update expo packages to SDK 51 versions

revert #2524

How

update expo packages to SDK 51 versions

Test Plan

tests

Copy link
Member Author

szdziedzic commented Sep 2, 2024

Copy link

github-actions bot commented Sep 2, 2024

Size Change: -1.06 kB (0%)

Total Size: 52.7 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.7 MB -1.06 kB (0%)

compressed-size-action

@szdziedzic szdziedzic changed the title [eas-cli] update @expo packages versions [eas-cli] update expo packages to SDK 51 versions Sep 2, 2024
@szdziedzic szdziedzic marked this pull request as ready for review September 2, 2024 16:31
@szdziedzic szdziedzic force-pushed the 09-02-_eas-cli_update_expo_packages_versions branch from ad28019 to 28c6181 Compare September 2, 2024 16:43
Copy link
Contributor

@radoslawkrzemien radoslawkrzemien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the failing tests are resolved

Copy link
Member

@wschurman wschurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check test failures before landing.

@szdziedzic szdziedzic force-pushed the 09-02-_eas-cli_use_getconfig_from_projectdir_node_modules__expo_config_if_available branch from b5f49ac to 9cd41f7 Compare October 14, 2024 11:35
@szdziedzic szdziedzic force-pushed the 09-02-_eas-cli_update_expo_packages_versions branch from 28c6181 to 32b6ffa Compare October 14, 2024 11:35
Copy link

github-actions bot commented Oct 14, 2024

Subscribed to pull request

File Patterns Mentions
**/* @khamilowicz, @sjchmiela

Generated by CodeMention

@szdziedzic szdziedzic force-pushed the 09-02-_eas-cli_update_expo_packages_versions branch 3 times, most recently from e5b2666 to c72bac0 Compare October 15, 2024 08:28
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.92%. Comparing base (cf8e715) to head (209bb28).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2530      +/-   ##
==========================================
- Coverage   52.93%   52.92%   -0.01%     
==========================================
  Files         570      570              
  Lines       21828    21862      +34     
  Branches     4293     4302       +9     
==========================================
+ Hits        11553    11568      +15     
- Misses      10241    10260      +19     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic force-pushed the 09-02-_eas-cli_use_getconfig_from_projectdir_node_modules__expo_config_if_available branch 2 times, most recently from da4d277 to 8536a7a Compare October 17, 2024 12:57
@szdziedzic szdziedzic force-pushed the 09-02-_eas-cli_update_expo_packages_versions branch from c72bac0 to 37edc6d Compare October 17, 2024 12:57
@szdziedzic szdziedzic force-pushed the 09-02-_eas-cli_use_getconfig_from_projectdir_node_modules__expo_config_if_available branch from 8536a7a to a2e16f4 Compare November 5, 2024 14:08
@szdziedzic szdziedzic force-pushed the 09-02-_eas-cli_update_expo_packages_versions branch 3 times, most recently from 475f369 to 8bca32d Compare November 5, 2024 14:50
@szdziedzic szdziedzic changed the title [eas-cli] update expo packages to SDK 51 versions [eas-cli] update expo packages Nov 5, 2024
@szdziedzic szdziedzic force-pushed the 09-02-_eas-cli_update_expo_packages_versions branch from 8bca32d to 4597644 Compare November 5, 2024 15:01
@szdziedzic szdziedzic force-pushed the 09-02-_eas-cli_update_expo_packages_versions branch from 8e25ea3 to aa72718 Compare November 5, 2024 18:29
Copy link
Member Author

szdziedzic commented Nov 5, 2024

Merge activity

  • Nov 5, 1:33 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 5, 1:35 PM EST: Graphite rebased this pull request as part of a merge.
  • Nov 5, 1:36 PM EST: A user merged this pull request with Graphite.

@szdziedzic szdziedzic changed the base branch from 09-02-_eas-cli_use_getconfig_from_projectdir_node_modules__expo_config_if_available to graphite-base/2530 November 5, 2024 18:33
@szdziedzic szdziedzic changed the base branch from graphite-base/2530 to main November 5, 2024 18:33
@szdziedzic szdziedzic force-pushed the 09-02-_eas-cli_update_expo_packages_versions branch from aa72718 to 209bb28 Compare November 5, 2024 18:34
Copy link

github-actions bot commented Nov 5, 2024

✅ Thank you for adding the changelog entry!

@szdziedzic szdziedzic merged commit a426164 into main Nov 5, 2024
7 checks passed
@szdziedzic szdziedzic deleted the 09-02-_eas-cli_update_expo_packages_versions branch November 5, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants