-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(eas-cli): add worker --alias
flag
#2551
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byCedric
requested review from
szdziedzic,
khamilowicz and
sjchmiela
as code owners
September 11, 2024 16:43
Size Change: +1.59 kB (0%) Total Size: 52.9 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2551 +/- ##
==========================================
- Coverage 52.28% 52.27% -0.01%
==========================================
Files 557 557
Lines 20982 20989 +7
Branches 4282 4283 +1
==========================================
Hits 10969 10969
- Misses 9152 9158 +6
- Partials 861 862 +1 ☔ View full report in Codecov by Sentry. |
kitten
approved these changes
Sep 11, 2024
szdziedzic
approved these changes
Sep 12, 2024
byCedric
force-pushed
the
@bycedric/eas-cli/deploy-flag-prod
branch
from
September 12, 2024 10:30
784c920
to
36a5831
Compare
byCedric
force-pushed
the
@bycedric/eas-cli/deploy-flag-alias
branch
from
September 12, 2024 10:38
39960fd
to
1a336a3
Compare
Co-authored-by: Szymon Dziedzic <szymon.dziedzic@swmansion.com>
✅ Thank you for adding the changelog entry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is stacked on top of #2548, since we use the alias mutation here too.
Why
This adds the
eas worker --alias <name>
, to assign a custom alias when deploying.How
--alias
and used the existing deployment alias mutationTest Plan
$ eas worker --alias
$ eas worker --prod --alias