Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(eas-cli): add worker --alias flag #2551

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Sep 11, 2024

This PR is stacked on top of #2548, since we use the alias mutation here too.

Why

This adds the eas worker --alias <name>, to assign a custom alias when deploying.

How

  • Added --alias and used the existing deployment alias mutation

Test Plan

$ eas worker --alias image
$ eas worker --prod --alias image

Copy link

github-actions bot commented Sep 11, 2024

Size Change: +1.59 kB (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB +1.59 kB (0%)

compressed-size-action

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 52.27%. Comparing base (feaa8cb) to head (7076921).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/worker/deploy.ts 0.00% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2551      +/-   ##
==========================================
- Coverage   52.28%   52.27%   -0.01%     
==========================================
  Files         557      557              
  Lines       20982    20989       +7     
  Branches     4282     4283       +1     
==========================================
  Hits        10969    10969              
- Misses       9152     9158       +6     
- Partials      861      862       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@byCedric byCedric force-pushed the @bycedric/eas-cli/deploy-flag-prod branch from 784c920 to 36a5831 Compare September 12, 2024 10:30
Base automatically changed from @bycedric/eas-cli/deploy-flag-prod to main September 12, 2024 10:37
@byCedric byCedric force-pushed the @bycedric/eas-cli/deploy-flag-alias branch from 39960fd to 1a336a3 Compare September 12, 2024 10:38
Co-authored-by: Szymon Dziedzic <szymon.dziedzic@swmansion.com>
Copy link

✅ Thank you for adding the changelog entry!

@byCedric byCedric merged commit a404bb3 into main Sep 12, 2024
6 checks passed
@byCedric byCedric deleted the @bycedric/eas-cli/deploy-flag-alias branch September 12, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants