Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Add --environment argument to worker:deploy #2557

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

kitten
Copy link
Member

@kitten kitten commented Sep 12, 2024

Why

This adds EAS Env "pulling" to worker deployments, i.e. pipes environment variables from EAS into the worker deployment.

How

Reuses existing --environment definition. Overriding the help description is TBD.

Test Plan

Manually tested

Copy link

github-actions bot commented Sep 12, 2024

Size Change: -2.56 kB (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB -2.56 kB (0%)

compressed-size-action

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 52.23%. Comparing base (2fb079d) to head (376c619).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/worker/assets.ts 22.23% 7 Missing ⚠️
packages/eas-cli/src/commands/worker/deploy.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2557      +/-   ##
==========================================
- Coverage   52.24%   52.23%   -0.01%     
==========================================
  Files         557      557              
  Lines       21006    21013       +7     
  Branches     4291     4294       +3     
==========================================
+ Hits        10973    10974       +1     
- Misses       9168     9174       +6     
  Partials      865      865              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kitten kitten force-pushed the @kitten/feat/environment-argument branch from 4dda838 to 376c619 Compare September 13, 2024 12:08
Copy link

✅ Thank you for adding the changelog entry!

@kitten kitten merged commit 5c553ce into main Sep 13, 2024
9 checks passed
@kitten kitten deleted the @kitten/feat/environment-argument branch September 13, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants