Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(eas-cli): add worker --export-dir to select exported directory #2560

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

byCedric
Copy link
Member

Why

With npx expo export you can override the default dist output folder through --output-dir. This adds support to eas worker --export-dir to change the dist folder too.

How

  • Added eas worker --export-dir flag
  • Swapped path.resolve to path.join to use our own validation (when the folder doesn't exist)

Test Plan

  • $ npx expo export --output-dir ./build
  • $ eas worker --export-dir ./build

@byCedric byCedric force-pushed the @bycedric/eas-cli/worker-deploy-dist-folder branch from 91575d3 to da0af60 Compare September 13, 2024 12:57
Copy link

✅ Thank you for adding the changelog entry!

Copy link

Size Change: -1.22 kB (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB -1.22 kB (0%)

compressed-size-action

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.23%. Comparing base (5c553ce) to head (da0af60).

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/worker/deploy.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2560   +/-   ##
=======================================
  Coverage   52.23%   52.23%           
=======================================
  Files         557      557           
  Lines       21013    21013           
  Branches     4294     4294           
=======================================
  Hits        10974    10974           
  Misses       9174     9174           
  Partials      865      865           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@byCedric byCedric merged commit 66ce64e into main Sep 13, 2024
9 checks passed
@byCedric byCedric deleted the @bycedric/eas-cli/worker-deploy-dist-folder branch September 13, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants