Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(eas-cli): add worker --json support for 3rd parties and custom tooling #2561

Merged
merged 6 commits into from
Sep 13, 2024

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Sep 13, 2024

Why

With eas worker --json, we can integrate with other tooling (such as expo-github-action). This adds support for exactly that.

How

  • Swapped the beta warning from Log.warn to console.warn, avoiding polluting the JSON output
  • Added --json only output to eas worker --json command

Test Plan

eas worker --json --non-interactive image
eas worker --alias test-json --json --non-interactive image
eas worker --prod --json --non-interactive image
eas worker --prod --alias test-json --json --non-interactive image

Copy link

github-actions bot commented Sep 13, 2024

Size Change: +2.17 kB (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB +2.17 kB (0%)

compressed-size-action

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 5.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 52.21%. Comparing base (66ce64e) to head (904c15a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/worker/deploy.ts 5.00% 14 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2561      +/-   ##
==========================================
- Coverage   52.23%   52.21%   -0.01%     
==========================================
  Files         557      557              
  Lines       21013    21021       +8     
  Branches     4294     4300       +6     
==========================================
+ Hits        10974    10975       +1     
- Misses       9174     9179       +5     
- Partials      865      867       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kadikraman kadikraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯

Copy link

✅ Thank you for adding the changelog entry!

@byCedric byCedric merged commit fa32629 into main Sep 13, 2024
9 checks passed
@byCedric byCedric deleted the @bycedric/eas-cli/worker-deploy-json branch September 13, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants