Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(eas-cli): polish the dev domain prompt #2564

Merged
merged 4 commits into from
Sep 14, 2024

Conversation

byCedric
Copy link
Member

Why

In early user testing it showed that "dev domain" is too ambiguous. Just polished the prompt to make it more clear what it is, and what's allowed.

How

  • Added .(staging.)expo.app suffix to show the base URL
  • Renamed dev domain to project URL
  • Updated validation messages

Test Plan

Kapture.2024-09-14.at.11.28.24.mp4

Copy link

github-actions bot commented Sep 14, 2024

Size Change: +438 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB +438 B (0%)

compressed-size-action

Copy link

✅ Thank you for adding the changelog entry!

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 15.38462% with 33 lines in your changes missing coverage. Please review.

Project coverage is 52.11%. Comparing base (819259a) to head (daf2bdd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/worker/deployment.ts 15.16% 24 Missing and 4 partials ⚠️
packages/eas-cli/src/worker/queries.ts 0.00% 3 Missing ⚠️
packages/eas-cli/src/commands/worker/deploy.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2564      +/-   ##
==========================================
- Coverage   52.16%   52.11%   -0.05%     
==========================================
  Files         559      559              
  Lines       21062    21092      +30     
  Branches     4308     4314       +6     
==========================================
+ Hits        10985    10990       +5     
- Misses       9203     9224      +21     
- Partials      874      878       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@byCedric byCedric merged commit 539ef8f into main Sep 14, 2024
9 checks passed
@byCedric byCedric deleted the @bycedric/eas-cli/deploy-dev-domain branch September 14, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants