Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(eas-cli): always default to static uploads and add modified time #2565

Merged
merged 7 commits into from
Sep 14, 2024

Conversation

byCedric
Copy link
Member

Why

This change makes eas deploy always assume we are uploading a static project. That means you could upload just a folder with output/index.html file in an Expo project.

How

  • Rewrote project detection to assume static projects by default (making single also work)
  • Only switch to server when output: server is detected, just by folder names
  • Add created X ago to the project type in deploy output

Test Plan

image

Copy link

github-actions bot commented Sep 14, 2024

Size Change: +956 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB +956 B (0%)

compressed-size-action

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 3.44828% with 28 lines in your changes missing coverage. Please review.

Project coverage is 52.11%. Comparing base (539ef8f) to head (9450ef0).

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/worker/deploy.ts 4.77% 20 Missing ⚠️
packages/eas-cli/src/worker/deployment.ts 0.00% 4 Missing and 1 partial ⚠️
packages/eas-cli/src/commands/worker/alias.ts 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2565      +/-   ##
==========================================
+ Coverage   52.11%   52.11%   +0.01%     
==========================================
  Files         559      559              
  Lines       21092    21093       +1     
  Branches     4314     4313       -1     
==========================================
+ Hits        10990    10991       +1     
- Misses       9224     9225       +1     
+ Partials      878      877       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@byCedric byCedric force-pushed the @bycedric/eas-cli/deploy-project-detection branch from 8552445 to 263c2f4 Compare September 14, 2024 11:53
@byCedric byCedric force-pushed the @bycedric/eas-cli/deploy-project-detection branch from 263c2f4 to 9450ef0 Compare September 14, 2024 12:01
Copy link

✅ Thank you for adding the changelog entry!

@byCedric byCedric merged commit 7847b52 into main Sep 14, 2024
6 checks passed
@byCedric byCedric deleted the @bycedric/eas-cli/deploy-project-detection branch September 14, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants