-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(eas-cli): always default to static uploads and add modified time #2565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byCedric
requested review from
szdziedzic,
khamilowicz and
sjchmiela
as code owners
September 14, 2024 11:20
kitten
approved these changes
Sep 14, 2024
Size Change: +956 B (0%) Total Size: 52.9 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2565 +/- ##
==========================================
+ Coverage 52.11% 52.11% +0.01%
==========================================
Files 559 559
Lines 21092 21093 +1
Branches 4314 4313 -1
==========================================
+ Hits 10990 10991 +1
- Misses 9224 9225 +1
+ Partials 878 877 -1 ☔ View full report in Codecov by Sentry. |
byCedric
force-pushed
the
@bycedric/eas-cli/deploy-project-detection
branch
from
September 14, 2024 11:53
8552445
to
263c2f4
Compare
byCedric
force-pushed
the
@bycedric/eas-cli/deploy-project-detection
branch
from
September 14, 2024 12:01
263c2f4
to
9450ef0
Compare
✅ Thank you for adding the changelog entry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This change makes
eas deploy
always assume we are uploading a static project. That means you could upload just a folder withoutput/index.html
file in an Expo project.How
static
projects by default (makingsingle
also work)server
whenoutput: server
is detected, just by folder namescreated X ago
to the project type in deploy outputTest Plan