Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eas-cli): make email case insensitive during apple auth #2659

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

byCedric
Copy link
Member

Why

After fixing Apple authentication, we received some reports of unexpected "invalid account name and/or password" errors. These were related to the case sensitivity of the email, used when generating the proof of credentials for Apple (using RSP6a).

This fixes that.

How

  • Make email case insensitive when authenticating with Apple

Test Plan

  • eas credentials
  • Select iOS
  • Try to authenticate using a capital letter in the account name (or email)

@byCedric byCedric requested a review from kitten October 28, 2024 09:57
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela

Generated by CodeMention

Copy link

✅ Thank you for adding the changelog entry!

Copy link

Size Change: -864 B (0%)

Total Size: 53 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53 MB -864 B (0%)

compressed-size-action

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.91%. Comparing base (3e6cf78) to head (0e661d0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2659   +/-   ##
=======================================
  Coverage   52.91%   52.91%           
=======================================
  Files         570      570           
  Lines       21750    21750           
  Branches     4263     4263           
=======================================
  Hits        11506    11506           
  Misses      10213    10213           
  Partials       31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@byCedric byCedric merged commit dd19086 into main Oct 28, 2024
10 checks passed
@byCedric byCedric deleted the @bycedric/eas-cli/fix-case-insensitive-apple-auth branch October 28, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants