-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] compute fingerprint on each build #2663
[eas-cli] compute fingerprint on each build #2663
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Subscribed to pull request
Generated by CodeMention |
6e6ea65
to
3c71784
Compare
Size Change: -2.41 kB (0%) Total Size: 52.7 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2663 +/- ##
==========================================
- Coverage 52.93% 52.87% -0.05%
==========================================
Files 570 571 +1
Lines 21866 21898 +32
Branches 4306 4315 +9
==========================================
+ Hits 11572 11576 +4
- Misses 10260 10288 +28
Partials 34 34 ☔ View full report in Codecov by Sentry. |
if (options.workflow === 'managed') { | ||
fingerprintOptions.ignorePaths = ['android/**/*', 'ios/**/*']; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for this PR, but I wonder if it makes sense to hoist the workflow discrimination into the fingerprint library itself? (So that this stays consistent with https://github.com/expo/expo/blob/main/packages/expo-updates/utils/src/createFingerprintAsync.ts#L22). I don't foresee the logic changing, but it does seem fairly core to what fingerprint selects. Maybe make it an argument/option that, when provided, sets these ignore paths by default? cc @Kudo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good to me. maybe we can add an isCNG: boolean
option.
552d04f
to
572a238
Compare
✅ Thank you for adding the changelog entry! |
Why
This PR computes a fingerprint for each build to support soft fingerprinting.
Testing