-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] Default build-logger-level to debug when EXPO_DEBUG is set #2676
[build] Default build-logger-level to debug when EXPO_DEBUG is set #2676
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @wschurman and the rest of your teammates on Graphite |
Size Change: +32 B (0%) Total Size: 52.9 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2676 +/- ##
==========================================
- Coverage 52.94% 52.94% -0.00%
==========================================
Files 576 576
Lines 22101 22103 +2
Branches 4335 4336 +1
==========================================
+ Hits 11699 11700 +1
- Misses 10368 10369 +1
Partials 34 34 ☔ View full report in Codecov by Sentry. |
Subscribed to pull request
Generated by CodeMention |
4bc6bd8
to
256e7bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me, and I believe it would be useful.
I'm curious what @sjchmiela thinks about it.
256e7bc
to
f5bb6af
Compare
f5bb6af
to
4bc0102
Compare
✅ Thank you for adding the changelog entry! |
Why
It's convenient to have this be the default value when trying to debug, so that the whole build can be used to debug. Not set on this, but wanted to see what others thought.
Closes ENG-14060.
How
Default when
Log.isDebug
is true and flag isn't provided.Test Plan
EXPO_DEBUG=1 neas build
, see debug logs in build.