Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-509][submit] Fix local archive prompt #273

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Conversation

barthap
Copy link
Contributor

@barthap barthap commented Mar 12, 2021

Checklist

Why

Fixes ENG-509. When running eas submit -p ios and selected local archive path, the prompt asked for .aab file instead of .ipa.

How

Modified prompt messages to be platform-dependant.

Test Plan

Tested by running command locally for both platforms.

@barthap barthap requested a review from dsokal March 12, 2021 09:41
@linear
Copy link

linear bot commented Mar 12, 2021

ENG-509 Update copy on eas submit ios local app binary

Current prompts is ? Path to the app archive file (aab or apk): › /path/to/your/archive.aab

This should suggest an ipa

@github-actions
Copy link

Size Change: -9 B (0%)

Total Size: 32.8 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 32.8 MB -9 B (0%)

compressed-size-action

@barthap barthap merged commit 5eb80d1 into main Mar 12, 2021
@barthap barthap deleted the @barthap/archive-path branch March 12, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants