[eas-cli] verify that "name" in app.sjon can be used as iOS target name #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkozyra95
force-pushed
the
@wkozyra95/verify-that-target-name-is-not-empty
branch
from
0eca64b
to
7b243ba
Compare
|
Size Change: +622 B (0%) Total Size: 32.8 MB
|
dsokal
reviewed
Mar 18, 2021
Comment on lines
+49
to
+51
| if (!commandCtx.exp.name) { | ||
| throw new Error('"expo.name" is required in your app.json'); | ||
| } |
There was a problem hiding this comment.
Is this check necessary? I think it is always defined.
There was a problem hiding this comment.
I prefer to check that just in case, e.g. someone can have name: '' in app.json
dsokal
approved these changes
Mar 18, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Why
If the name does not contain any alphanumeric characters sanitized version is empty string and can't be used as target name
How
verify before and after sanitization whether
exp.nameis emptyTest Plan
run build with invalid name