add commands for managing webhooks #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2.47 kB (0%) Total Size: 32.9 MB
|
dsokal
force-pushed
the
@dsokal/webhooks
branch
3 times, most recently
from
26930fb
to
6ff99e1
Compare
barthap
approved these changes
Apr 9, 2021
| import Log from '../log'; | ||
| import { promptAsync } from '../prompts'; | ||
|
|
||
| export async function prepareInputParams( |
There was a problem hiding this comment.
Suggested change
| export async function prepareInputParams( | |
| export async function prepareInputParamsAsync( |
| } | ||
| } | ||
|
|
||
| async function fetchWebhooksByAppId(appId: string): Promise<WebhookFragment[]> { |
There was a problem hiding this comment.
Suggested change
| async function fetchWebhooksByAppId(appId: string): Promise<WebhookFragment[]> { | |
| async function fetchWebhooksByAppIdAsync(appId: string): Promise<WebhookFragment[]> { |
| } | ||
| } catch (err) { | ||
| spinner.fail( | ||
| `Something went wrong and we couldn't fetch the webhook list ${projectFullName}` |
There was a problem hiding this comment.
Suggested change
| `Something went wrong and we couldn't fetch the webhook list ${projectFullName}` | |
| `Something went wrong and we couldn't fetch the webhooks for project ${projectFullName}` |
🤔
wkozyra95
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Why
https://github.com/expo/universe/pull/7305 added infra for webhooks management.
This PR adds a bunch of new commands for webhooks management:
webhook:create,webhook:view,webhook:list,webhook:update,webhook:delete.How
webhook:create.webhook:list.webhook:view.webhook:update.webhook:deleteTest Plan
Tested manually.