Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use special Expo SDK runtime version for managed projects #336

Merged
merged 2 commits into from
Apr 15, 2021

Conversation

wschurman
Copy link
Member

@wschurman wschurman commented Apr 14, 2021

Why

This PR adds support for a special runtime version indicating that the runtime is an expo SDK preset runtime (SDK version). With this special runtime version the user will be able to load the app in Expo Go (as long as expo go has that runtime version). Otherwise the user will need to use the dev client to develop their app.

From https://github.com/expo/universe/pull/7299:

How

Add code to default the runtimeVersion to the SDK version if in managed and the runtime version is not specified.

Test Plan

In a managed project without runtimeVersion specified:

> /Users/wschurman/expo/eas-cli/node_modules/.bin/eas branch:publish main
✔ Generating runtime version from sdk version
✔ Linked to project @wschurman/watwat
✔ Building bundle with expo-cli...
...
✔ Uploaded assets!
✔ Please enter a publication message. … woo2
✔ Published!
project        @wschurman/watwat
branch         main
runtimeVersion exposdk:40.0.0
groupID        c2ad7581-5e10-41a6-9c1d-e01eeb604dce
message        woo2

> /Users/wschurman/expo/eas-cli/node_modules/.bin/eas branch:list
Branches with their most recent update group:
┌────────┬─────────────────────────────────────┬────────────────────────┬──────────────────────────────────────┐
│ branch │ update description                  │ update runtime version │ update group ID                      │
├────────┼─────────────────────────────────────┼────────────────────────┼──────────────────────────────────────┤
│ main   │ "woo2" (2 minutes ago by wschurman) │ exposdk:40.0.0         │ c2ad7581-5e10-41a6-9c1d-e01eeb604dce │
└────────┴─────────────────────────────────────┴────────────────────────┴──────────────────────────────────────┘

@wschurman wschurman requested review from fson and jkhales April 14, 2021 19:57
@github-actions
Copy link

github-actions bot commented Apr 14, 2021

Size Change: +7.63 kB (0%)

Total Size: 32.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 32.9 MB +7.63 kB (0%)

compressed-size-action

@wschurman wschurman force-pushed the @wschurman/sdk-runtime-version branch from 14d2159 to 1c4d0e5 Compare April 14, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants