allow for registering devices when building app for internal distribution #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsokal
changed the title
dsokal
force-pushed
the
@dsokal/register-devices-when-running-build
branch
from
3ec4aad
to
57687f9
Compare
|
Size Change: +40 B (0%) Total Size: 32.9 MB
|
wkozyra95
approved these changes
Apr 19, 2021
dsokal
force-pushed
the
@dsokal/register-devices-when-running-build
branch
from
57687f9
to
c7d3a08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Why
Currently, if the user is running an internal distribution build but they haven't registered any devices yet, we throw an error
Run 'eas device:create' to register your devices first.This PR makes it possible to register the devices without the need to run another command.
How
I reused the device registration logic from
device:create.Test Plan
Tested manually.