Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow cascadingDeleteCause to be passed in via public deletion mutator methods #248

Conversation

wschurman
Copy link
Member

@wschurman wschurman commented Sep 26, 2024

Why

When doing large batch deletions like the ones specified in #243, the case is usually to serially do a bunch of deletions ahead of a cascade in order to decrease memory usage.

This has one issue: these become normal deletions. Even though they're somewhat "part" of this cascade deletion.

Some privacy policies make use of the cascadingDeleteCause in order to determine delete-ability. Because of this, these "cascading" deletes should have the cause.

How

Add the ability to manually specify it.

Test Plan

N/A

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @wschurman and the rest of your teammates on Graphite Graphite

@wschurman wschurman marked this pull request as ready for review September 26, 2024 22:57
@wschurman wschurman closed this Sep 26, 2024
Copy link
Member Author

Closing since it's likely this library should just provide a batch deletion abstraction instead and inject it internally there. This field is meant to be constructed recursively only by the deletion mutator.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c2ae21b) to head (b1f8995).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #248   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           72        72           
  Lines         1964      1964           
  Branches       276       276           
=========================================
  Hits          1964      1964           
Flag Coverage Δ
integration 100.00% <100.00%> (ø)
unittest 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant