[notifications] Add support for custom managed workflow #12465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
changed the title
brentvatne
approved these changes
Apr 8, 2021
EvanBacon
deleted the
@evanbacon/expo-notifications/added-support-for-currentFullName
branch
cruzach
reviewed
Apr 9, 2021
| @@ -30,7 +30,8 @@ export default async function getExpoPushTokenAsync(options: Options = {}): Prom | |||
|
|
|||
| const deviceId = options.deviceId || (await getDeviceIdAsync()); | |||
|
|
|||
| const experienceId = options.experienceId || (Constants.manifest && Constants.manifest.id); | |||
| const experienceId = | |||
| options.experienceId || Constants.manifest?.currentFullName || Constants.manifest?.id; | |||
There was a problem hiding this comment.
Just in case there are any differences introduced in Constants.manifest?.currentFullName, shouldn't we change this to
options.experienceId || Constants.manifest?.id || Constants.manifest?.currentFullName;
so on the off chance there's a bug with Constants.manifest?.currentFullName, we don't change existing users' push tokens
There was a problem hiding this comment.
Added my thoughts to the universe PR, linked below.
brentvatne
pushed a commit
that referenced
this pull request
Apr 21, 2021
* Added support for currentFullName * Updated docs * Update CHANGELOG.md
This was referenced May 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The bare workflow must support notifications out of the box in order to use managed EAS build. This PR implements support for bare workflow after landing this expo/config change and updating expo-constants expo/expo-cli#3376
How
Use
currentFullName || idinstead ofidto get the legacy managed project id.Test Plan