[face-detector] Migrate interface to expo-modules-core #12936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsapeta
force-pushed
the
@tsapeta/remove-face-detector-interface
branch
from
ce243b4 to
9da4f53
Compare
expo-bot
reviewed
May 17, 2021
There was a problem hiding this comment.
The review previously left here is no longer valid, jump to the latest one 👉 #12936 (review)
tsapeta
force-pushed
the
@tsapeta/remove-face-detector-interface
branch
from
9da4f53 to
9bee15c
Compare
expo-bot
reviewed
May 17, 2021
There was a problem hiding this comment.
The review previously left here is no longer valid, jump to the latest one 👉 #12936 (review)
Co-authored-by: Expo CI <34669131+expo-ci@users.noreply.github.com>
expo-bot
reviewed
May 17, 2021
There was a problem hiding this comment.
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.
I've found some issues in your pull request that should be addressed (click on them to expand) 👇
⚠️ Warning: Missing changelog entries
If you made some API or behavioral changes, please add an appropriate entry to the following changelogs:
Generated by ExpoBot 🤖 against 8862ad0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Followup #12718
How
Removed
unimodules-face-detector-interfacepackage and replaced its references to the new interface living inexpo-modules-core. I also noticed that some interfaces have the same name as classes, so I suffixed them withInterfaceto distinguish them easily.Test Plan
NCL examples of modified packages seem to work as expected