fix: crash of file system when try to read cache dir file on android #13232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
reviewed
Jun 10, 2021
There was a problem hiding this comment.
The review previously left here is no longer valid, jump to the latest one 👉 #13232 (review)
numandev1
changed the title
numandev1
changed the title
numandev1
force-pushed
the
fix/crasah-filesystem-cache-dir
branch
from
85e5d27 to
67fe814
Compare
expo-bot
reviewed
Jun 10, 2021
There was a problem hiding this comment.
The review previously left here is no longer valid, jump to the latest one 👉 #13232 (review)
lukmccall
requested changes
Jun 16, 2021
packages/expo-file-system/android/src/main/java/expo/modules/filesystem/FileSystemModule.java
Outdated
Show resolved
Hide resolved
numandev1
force-pushed
the
fix/crasah-filesystem-cache-dir
branch
from
67fe814 to
82d02b9
Compare
expo-bot
reviewed
Jun 16, 2021
There was a problem hiding this comment.
The review previously left here is no longer valid, jump to the latest one 👉 #13232 (review)
expo-bot
added
bot: passed checks
numandev1
force-pushed
the
fix/crasah-filesystem-cache-dir
branch
from
82d02b9 to
128e1ce
Compare
expo-bot
reviewed
Jun 16, 2021
There was a problem hiding this comment.
The review previously left here is no longer valid, jump to the latest one 👉 #13232 (review)
|
@lukmccall i have done requested changes |
lukmccall
reviewed
Jun 16, 2021
lukmccall
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #5408
Why
Should resolve to
{ exists: false }instead of throwingHow
getInfoAsyncthrows an errorFile <file path isn't readable>Steps to Reproduce
try to read file from
cacheDirectoryit will throw an exception which this PR has fixedChecklist
expo build(eg: updated@expo/xdl).expo prebuild& EAS Build (eg: updated a module plugin).Reproducible Demo
https://snack.expo.io/@charliecruzan/getinfoasyncerror