[expo-av] Fixed an issue with Audio Interruption Mode not correctly being set on Android #13236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The audio interruption mode was not correctly set when using this code:
If you started audio in another app and then played audio in my app, it would duck the other audio, rather than interrupting it.
How
The issue was caused by the case statement incorrectly falling through due to a lack of
break
statement. This caused themAudioInterruptionMode
value to first be set to the correctDO_NOT_MIX
value, before then being set toDUCK_OTHERS
incorrectly.Adding the break statement is all that is needed to fix the issue.
Test Plan
Tested this manually in my project.
Checklist
expo build
(eg: updated@expo/xdl
).expo prebuild
& EAS Build (eg: updated a module plugin).