-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated vendored react-native-webview to v13.2.2 #22913
Updated vendored react-native-webview to v13.2.2 #22913
Conversation
@@ -287,33 +287,35 @@ const config: VendoringTargetConfig = { | |||
`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kudo here's some changes that I'd appreciate a review on
@@ -590,6 +590,24 @@ const vendoredModulesConfig: { [key: string]: VendoredModuleConfig } = { | |||
sourceAndroidPackage: 'com.reactnativecommunity.webview', | |||
targetAndroidPackage: 'versioned.host.exp.exponent.modules.api.components.webview', | |||
}, | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kudo same here :)
97affe5
to
b0bee06
Compare
find: /@implementation RNCWebViewManager\s*{/, | ||
replaceWith: '$&\n NSString *_scopeKey;', | ||
}, | ||
{ | ||
paths: 'RNCWebViewManager.m', | ||
paths: 'RNCWebViewManager.mm', | ||
find: '*webView = [RNCWebView new];', | ||
replaceWith: '*webView = [RNCWebView new];\n webView.scopeKey = _scopeKey;', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please help to double check all these transforms are updated correctly. the [RNCWebView new]
seems not there in the current code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, missed that, will double check to see if all transforms got updated.
Perhaps we should make the vendoring process error out if a transform never got applied?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should make the vendoring process error out if a transform never got applied?
sounds good 👍
Thank you for the catch @Kudo, I've checked that all code transformations for iOS get applied correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm impressed how this package migrates to Kotlin and also back to Java at the same time. RNCWebViewPackage
has been migrated from Kotlin to Java, there are a few new files in Java and two new files in Kotlin 😂
Why
SDK49
How
It needed some changes to the legacy vendoring code. The new version stores native files in separate folders for new and old arch and uses gradle files to combine two folders.
Test Plan
Tested manually on both platforms.
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).