Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go] upgrade @react-native-picker/picker to 2.4.10 #22919

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

keith-kurak
Copy link
Contributor

Why

Upgrade @react-native-picker/picker vendored module.

How

Ran et uvm -m @react-native-picker/picker.

Added PickerIOS tests to demo selectionColor prop, the only change since SDK 48.

Test Plan

Build Expo Go unversioned locally, tested NCL on iOS/ Android.

Checklist

@keith-kurak keith-kurak marked this pull request as ready for review June 15, 2023 14:36
@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Jun 15, 2023
Copy link
Member

@tsapeta tsapeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a new test!

@keith-kurak keith-kurak merged commit f29d394 into main Jun 19, 2023
@keith-kurak keith-kurak deleted the keith/upgrade-vendor-module-react-native-picker branch June 19, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants