Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android][sqlite] Migrate to Expo Modules API #23115

Merged
merged 4 commits into from
Jun 27, 2023

Conversation

alanjhughes
Copy link
Collaborator

@alanjhughes alanjhughes commented Jun 26, 2023

Why

Continue migration of modules to new API
closes ENG-8373

How

Followed typical migration steps

Test Plan

All tests ✅

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Jun 26, 2023
@alanjhughes alanjhughes marked this pull request as ready for review June 26, 2023 22:31
@alanjhughes alanjhughes requested a review from Kudo as a code owner June 26, 2023 22:31
@alanjhughes alanjhughes force-pushed the @alanhughes/android/sqlite branch from 3ce0b2e to e80ed22 Compare June 27, 2023 08:19
@alanjhughes alanjhughes force-pushed the @alanhughes/android/sqlite branch from e80ed22 to cdccf15 Compare June 27, 2023 10:05
Copy link
Contributor

@Kudo Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🚀🚀

@alanjhughes alanjhughes merged commit 09ee958 into expo:main Jun 27, 2023
@alanjhughes alanjhughes deleted the @alanhughes/android/sqlite branch June 27, 2023 13:44
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Jun 28, 2023
@nickcruz
Copy link

nickcruz commented Aug 18, 2023

This is awesome!

What version of expo-sqlite can we expect this to come out on?

Edit: ✅ Never mind, I see it's out in 11.3.1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants