-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apple TV support 1: podspec and code changes for commonly used modules #24329
Apple TV support 1: podspec and code changes for commonly used modules #24329
Conversation
ENG-10042 Add Apple TV support to Expo SDK
Now that React Native TV repo is at 0.72.4, even with core, we can start adding partial support for Apple TV. Included:
Possibly included in future:
Excluded:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the commit history and open PRs on the ASN1Decoder repo, I think it's unlikely a PR will get merged and published, but I still think it's worth a shot (in parallel to this PR).
Just a few inline comments. Will defer to others for the higher-level review about tvos since I've never dealt with it.
PR has been submitted: filom/ASN1Decoder#39 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree about adding CI for this in a follow-up. Otherwise this will break pretty quickly since most of us ever build for TV locally.
Approving for my addressed comments, but wait for an approval from @Kudo as well to land as he is more familiar with it.
packages/expo-modules-core/ios/AppDelegates/ExpoAppDelegate.swift
Outdated
Show resolved
Hide resolved
packages/expo-modules-core/ios/AppDelegates/ExpoAppDelegate.swift
Outdated
Show resolved
Hide resolved
packages/expo-modules-core/ios/AppDelegates/ExpoAppDelegate.swift
Outdated
Show resolved
Hide resolved
- Public podspec is for iOS only - We need to include the source and README, and remove the pod dependency
a41b21c
to
5b97b8a
Compare
0897858
to
271749a
Compare
57f60ae
to
72a9b91
Compare
Why
First of a series of PRs to add Apple TV support for many (but not all) Expo SDK modules.
This PR makes Apple TV able to compile for apps using
react-native-tvos@0.72.4-0
and ONLY the following modules:How
#if TARGET_OS_TV
(for Objective C) or#if os(tvOS)
(for Swift)ASN1Decoder
Swift framework used byexpo-updates
, as the public podspec for that framework does not yet support tvOSTest Plan
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).