[go] update react-native-reanimated to support react-native 0.73 #25161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
force-pushed
the
@gabrieldonadel/sdk50/vendor-reanimated-with-73-support
branch
3 times, most recently
from
e68dfc4
to
8a17691
Compare
gabrieldonadel
force-pushed
the
@gabrieldonadel/sdk50/vendor-reanimated-with-73-support
branch
from
8a17691
to
9aa1e3e
Compare
gabrieldonadel
force-pushed
the
@gabrieldonadel/sdk50/vendor-reanimated-with-73-support
branch
from
9aa1e3e
to
eb60333
Compare
gabrieldonadel
requested review from
ide,
tsapeta and
brentvatne
as code owners
gabrieldonadel
requested review from
Kudo and
tsapeta
and removed request for
brentvatne,
ide and
tsapeta
Kudo
approved these changes
Nov 10, 2023
gabrieldonadel
deleted the
@gabrieldonadel/sdk50/vendor-reanimated-with-73-support
branch
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
…o#25161) # Why In order to have the react-native 73 upgrade PR ready by the end of the week we will need to temporarily bump react-native-reanimated to a nightly version, given that software-mansion/react-native-reanimated#4913 has not been officially released yet. # How `et uvm -m react-native-reanimated -c f06ee065904ebeac3fa72d4bda32ba3360bf49e7 -s 3.6.0-nightly-20231031-c56d44fd9` # Test Plan Run locally expo go unversined and bare-expo # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In order to have the react-native 73 upgrade PR ready by the end of the week we will need to temporarily bump
react-native-reanimated to a nightly version, given that software-mansion/react-native-reanimated#4913 has not been officially released yet.
How
et uvm -m react-native-reanimated -c f06ee065904ebeac3fa72d4bda32ba3360bf49e7 -s 3.6.0-nightly-20231031-c56d44fd9Test Plan
Run locally expo go unversined and bare-expo
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).