Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][core] Remove confusing usage of launch function #25988

Merged

Conversation

lukmccall
Copy link
Contributor

Why

Removes confusing usage of the launch function.
Adds information about the runOnQueue function.

@lukmccall lukmccall requested a review from tsapeta December 18, 2023 11:28
@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Dec 18, 2023
Copy link
Member

@amandeepmittal amandeepmittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one tiny suggestion.

docs/pages/modules/module-api.mdx Outdated Show resolved Hide resolved
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
@lukmccall lukmccall merged commit 8a86278 into main Dec 19, 2023
@lukmccall lukmccall deleted the @lukmccall/docs/fix-confusing-usage-of-launch-function branch December 19, 2023 10:59
onizam95 pushed a commit to onizam95/expo-av-drm that referenced this pull request Jan 15, 2024
# Why

Removes confusing usage of the `launch` function.
Adds information about the `runOnQueue` function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants